BPM stripping the bad characters

Post your Server Bug Report
User avatar
Matt Zornig
Contributor
Contributor
Posts: 230
Joined: 14 Feb 2017, 12:03
Has thanked: 34 times
Been thanked: 21 times

BPM stripping the bad characters

Unread post by Matt Zornig » 20 Feb 2017, 21:53

Code: Select all

=========================================================================================
VERSION: MADSONIC 6.2 | BUILD: 9080.619dd31.20161222.0327
REST: MADSONIC REST API v2.5.0, SUBSONIC REST API v1.14.0
OS: Linux 3.10.77 #8451 SMP Wed Jan 4 00:31:32 CST 2017 x86_64 GNU/Linux
SERVER: jetty/8.y.z-SNAPSHOT, java 1.8.0_121, Linux 3.10.77 (amd64) (330.8 MB / 457.0 MB)
HOST: Synology NAS 1815+ (DSM 6.0.2-8451 Update 9) | CPU: INTEL Atom C2538| ARCH: X64 | MEMORY: 6GB | HDD: 36TB, RAID6
BROWSER: FF 51.x
CLIENT: see browser
JAVA: ORACLE JDK 1.8.121
DESCRIPTION: see topic subject
REPRODUCIBLE: Yes. 
logged in as admin
=========================================================================================
Not much of a bug report, but some kind of feature request too.

While going through the serverlog, I saw a lot of those lines:

Code: Select all

[2017-02-20 21:17:42,516] WARN JaudiotaggerParser - Error when parsing tags in /path/to/music/superdupermusicfile.mp3 For input string: "159 BPM"
java.lang.NumberFormatException: For input string: "159 BPM"
	at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043)
	at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
	at java.lang.Double.parseDouble(Double.java:538)
	at org.madsonic.service.metadata.JaudiotaggerParser.getRawMetaData(JaudiotaggerParser.java:177)
	at org.madsonic.service.metadata.MetaDataParser.getMetaData(MetaDataParser.java:48)
	at org.madsonic.service.MediaFileService.createMediaFile(MediaFileService.java:911)
	at org.madsonic.service.MediaFileService.updateChildren(MediaFileService.java:729)
	at org.madsonic.service.MediaFileService.getChildrenOf(MediaFileService.java:330)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:418)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:422)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:422)
	at org.madsonic.service.MediaScannerService.doFolderScanLibrary(MediaScannerService.java:282)
	at org.madsonic.service.MediaScannerService.access$000(MediaScannerService.java:51)
	at org.madsonic.service.MediaScannerService$3.run(MediaScannerService.java:178)
Maybe its possible to strip all the alphabetical characters and leave only the numbers, when parsing the BPM tags?
That way, the log stays smaller, is easier to read and the BPM gets its way -hopefully correctly parsed- into the database.
These users thanked the author Matt Zornig for the post:
Madsonic

User avatar
Madsonic
Administrator
Administrator
Posts: 940
Joined: 07 Dec 2012, 03:58
Has thanked: 1116 times
Been thanked: 430 times
Contact:

Re: BPM stripping the bad characters

Unread post by Madsonic » 22 Feb 2017, 00:01

next snapshot build parse bpm values correctly if it contains "bpm" as string.

best regards

User avatar
Matt Zornig
Contributor
Contributor
Posts: 230
Joined: 14 Feb 2017, 12:03
Has thanked: 34 times
Been thanked: 21 times

Re: BPM stripping the bad characters

Unread post by Matt Zornig » 03 May 2018, 09:41

Code: Select all

=========================================================================================
VERSION: MADSONIC 6.3 | BUILD: 9840.8df1ddd.20180107.0710
REST: MADSONIC REST API v3.0.0, MADSONIC REST API v2.8.0, SUBSONIC REST API v1.16.0
OS: Linux 3.10.102 #15266 SMP Mon Mar 26 15:08:28 CST 2018 x86_64 GNU/Linux
SERVER: jetty/8.y.z-SNAPSHOT, java 1.8.0_172, Linux 3.10.102 (amd64)
HOST: Synology NAS 1815+ (DSM 6.1.6-15266 Update 1) | CPU: INTEL Atom C2538| ARCH: X64 | MEMORY: 16GB | HDD: 36TB, RAID6
BROWSER: FF 53.x
CLIENT: see browser
JAVA: ORACLE JDK 1.8.0_172
DESCRIPTION: as in the topic's subject or body
REPRODUCIBLE: Yes
logged in as admin
=========================================================================================
It does not work with this build.

Code: Select all

[2018-05-03 10:08:55,841] WARN JaudiotaggerParser - Error when parsing tags in /volume1/Media/B/Big L/1994 - Lifestylez Ov Da Poor & Dangerous [TAPE+Ap]/110. Big L - Da Graveyard.mp3 For input string: "j"
java.lang.NumberFormatException: For input string: "j"
	at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043)
	at sun.misc.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
	at java.lang.Double.parseDouble(Double.java:538)
	at org.madsonic.service.metadata.JaudiotaggerParser.getRawMetaData(JaudiotaggerParser.java:201)
	at org.madsonic.service.metadata.MetaDataParser.getMetaData(MetaDataParser.java:50)
	at org.madsonic.service.MediaFileService.createMediaFile(MediaFileService.java:928)
	at org.madsonic.service.MediaFileService.updateChildren(MediaFileService.java:746)
	at org.madsonic.service.MediaFileService.getChildrenOf(MediaFileService.java:333)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:508)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:512)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:512)
	at org.madsonic.service.MediaScannerService.scanFile(MediaScannerService.java:512)
	at org.madsonic.service.MediaScannerService.doFullScanLibrary(MediaScannerService.java:361)
	at org.madsonic.service.MediaScannerService.access$200(MediaScannerService.java:62)
	at org.madsonic.service.MediaScannerService$4.run(MediaScannerService.java:209)
110. Big L - Da Graveyard.rar
The mp3 file. Password is my mailadress. Please delete after checking.
(7.36 MiB) Downloaded 31 times

Post Reply